Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: sss_ssh_knownhosts with port number #7619

Closed
wants to merge 2 commits into from

Conversation

madhuriupadhye
Copy link
Contributor

Add tests cases with port numbers

src/tests/system/tests/test_ipa.py Fixed Show fixed Hide fixed
src/tests/system/tests/test_ipa.py Fixed Show fixed Hide fixed
src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ipa.py Show resolved Hide resolved
@madhuriupadhye madhuriupadhye marked this pull request as draft September 26, 2024 06:42
@madhuriupadhye madhuriupadhye force-pushed the sss_ssh_kh_port branch 3 times, most recently from e30e7d3 to 11a1f3d Compare September 26, 2024 09:22
src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved
@madhuriupadhye madhuriupadhye force-pushed the sss_ssh_kh_port branch 2 times, most recently from a6c593d to 37b93fa Compare September 26, 2024 15:45
@madhuriupadhye madhuriupadhye force-pushed the sss_ssh_kh_port branch 2 times, most recently from aec231e to 213a832 Compare September 27, 2024 07:17
@madhuriupadhye madhuriupadhye marked this pull request as ready for review September 27, 2024 08:07
src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_ipa.py Show resolved Hide resolved
@madhuriupadhye madhuriupadhye force-pushed the sss_ssh_kh_port branch 2 times, most recently from a1a5260 to abfa492 Compare September 27, 2024 14:06
@madhuriupadhye madhuriupadhye added Waiting for review no-backport This should go to target branch only. labels Oct 1, 2024
@madhuriupadhye madhuriupadhye requested a review from aplopez October 1, 2024 10:23
@aplopez
Copy link
Contributor

aplopez commented Oct 1, 2024

It seems something went wrong and we came back to an old state.

Copy link
Contributor

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Thanks.

Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test are for the new proxy so they should be using the builtwith client.features["knownhosts"] otherwise it looks good.

Add tests cases with port numbers

Signed-off-by: Madhuri Upadhye <[email protected]>
Mark builtwith for sss_ssh_knownhosts tests.
Update the marker of test to high to have basic
coverage in gating.

Signed-off-by: Madhuri Upadhye <[email protected]>
@alexey-tikhonov alexey-tikhonov added Ready to push Ready to push and removed Ready to push Ready to push labels Oct 15, 2024
@alexey-tikhonov
Copy link
Member

Pushed PR: #7619

  • master
    • 163b1e3 - Tests: Mark builtwith for knownhosts tests
    • 247797b - Tests: sss_ssh_knownhosts with port number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants