-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: sss_ssh_knownhosts with port number #7619
Conversation
68fb8fc
to
1a1ac03
Compare
e30e7d3
to
11a1f3d
Compare
a6c593d
to
37b93fa
Compare
aec231e
to
213a832
Compare
213a832
to
2fd6dac
Compare
a1a5260
to
abfa492
Compare
It seems something went wrong and we came back to an old state. |
abfa492
to
6a460f4
Compare
6a460f4
to
c8c5270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These test are for the new proxy so they should be using the builtwith client.features["knownhosts"] otherwise it looks good.
Add tests cases with port numbers Signed-off-by: Madhuri Upadhye <[email protected]>
c8c5270
to
72c61d7
Compare
4b94f05
to
137689e
Compare
Mark builtwith for sss_ssh_knownhosts tests. Update the marker of test to high to have basic coverage in gating. Signed-off-by: Madhuri Upadhye <[email protected]>
137689e
to
f02c0b9
Compare
Add tests cases with port numbers